Brijesh619 commented on code in PR #732:
URL: https://github.com/apache/atlas/pull/732#discussion_r3842630627
##########
dashboard/src/utils/__tests__/Utils.test.ts:
##########
@@ -878,11 +879,52 @@ describe('Utils', () => {
});
describe('sanitizeHtmlContent', () => {
- it('should sanitize HTML content', () => {
- const html = '<script>alert("xss")</script><p>Safe
content</p>';
- const result = sanitizeHtmlContent(html);
+ it('should allow configured positive HTML tags and attributes',
() => {
Review Comment:
Done. I've added a new test case for `sanitizeHtmlContent` to verify all the
edge cases, including non-string inputs (`null`, `undefined`), empty strings,
`mailto:` protocol links, and all the remaining allowed formatting tags
(`strong`, `u`, `ol`, `h2`-`h4`).
##########
dashboard/src/__mocks__/sanitize-html.ts:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const actualSanitizeModule = jest.requireActual('sanitize-html/index.js') as
any;
+
+const getSanitizeFn = () => {
Review Comment:
Done. I've fixed the indentation to 2 spaces to match the project's style
and completely removed `as any` by introducing a proper `SanitizeFn` type
definition for the dynamically loaded module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
