pawarprasad123 commented on code in PR #773:
URL: https://github.com/apache/atlas/pull/773#discussion_r4121710163
##########
dev-support/scripts/e2e-basic-search-count.sh:
##########
@@ -0,0 +1,56 @@
+#!/usr/bin/env bash
Review Comment:
Missing ASF license header (other scripts e.g. search_basic.sh have it)
##########
dashboard/src/components/Table/TablePagination.tsx:
##########
@@ -418,9 +420,15 @@ const TablePagination: React.FC<PaginationProps> = ({
) : (
<>
Showing {footerRangeStart.toLocaleString()}-
- {footerRangeEnd.toLocaleString()} of{' '}
- {totalDatasetRows.toLocaleString()}{' '}
- {totalDatasetRows === 1 ? 'record' : 'records'}
+ {footerRangeEnd.toLocaleString()} of{" "}
Review Comment:
mixes ' and " in the changed block (lines 423–426 vs surrounding code using
').
##########
dashboard/src/components/Table/TableLayout.tsx:
##########
@@ -329,6 +329,7 @@ const TableLayout: FC<TableProps> = ({
defaultColumnVisibility,
pageCount,
totalCount,
Review Comment:
Missing test case as per the Pr:
1) dashboard/src/components/Table/__tests__/TablePagination.test.tsx
Line: ~190 (after server-side test)
Add tests: (1) isServerSide=true, approximateCountExact=false → expect ~ and
(approx.); (2) approximateCountExact=true → no ~/tooltip.
2) dashboard/src/views/SearchResult/__tests__/SearchResult.test.tsx
Line: ~557 (mock data)
Add mock with approximateCountExact: true/false and assert prop passed to
TableLayout / footer text.
##########
dev-support/atlas-docker/Dockerfile.atlas:
##########
@@ -26,18 +26,22 @@ RUN update-java-alternatives --set
/usr/lib/jvm/java-1.${ATLAS_SERVER_JAVA_VERSI
COPY ./scripts/atlas.sh ${ATLAS_SCRIPTS}/
COPY ./dist/apache-atlas-${ATLAS_VERSION}-server.tar.gz /home/atlas/dist/
+COPY ./dist/postgresql-42.7.7.jar /home/atlas/dist/
Review Comment:
line 29,42-44
Document postgresql-42.7.7.jar in NOTICE / 3party-licenses/;
##########
dashboard/src/components/Table/TableLayout.tsx:
##########
@@ -329,6 +329,7 @@ const TableLayout: FC<TableProps> = ({
defaultColumnVisibility,
Review Comment:
Classic UI not updated
dashboardv2 still shows counts without the exact/approximate distinction.
Users on Classic UI get no benefit from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
