saksenasonali commented on code in PR #773:
URL: https://github.com/apache/atlas/pull/773#discussion_r4121878526


##########
dev-support/atlas-docker/Dockerfile.atlas:
##########
@@ -26,18 +26,22 @@ RUN update-java-alternatives --set 
/usr/lib/jvm/java-1.${ATLAS_SERVER_JAVA_VERSI
 
 COPY ./scripts/atlas.sh                                 ${ATLAS_SCRIPTS}/
 COPY ./dist/apache-atlas-${ATLAS_VERSION}-server.tar.gz /home/atlas/dist/
+COPY ./dist/postgresql-42.7.7.jar                       /home/atlas/dist/

Review Comment:
   Needed it for E2E docker validation
    The Atlas server tarball does not ship the PostgreSQL JDBC driver (no 
`postgresql*.jar` under `server/webapp/atlas/WEB-INF/lib`), and RDBMS storage 
needs `org.postgresql.Driver` on the classpath, which Atlas picks up from 
`${ATLAS_HOME}/libext/` (see `distro/src/bin/atlas_start.py`). The postgres 
overlay from ATLAS-5219 mounts 
`config/atlas/postgres/atlas-application.properties` but never installs the 
driver, so `ATLAS_BACKEND=postgres` fails to start. Since the default `.env` 
and the CI docker job both use `ATLAS_BACKEND=hbase`, that gap isn't hit in CI.
    
   I only needed it to stand up a postgres-backed Atlas locally to verify 
`approximateCountExact` against a live API. That's local validation, not part 
of this change, so this PR now touches only the model, search, and UI. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to