[ 
https://issues.apache.org/jira/browse/ATLAS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951908#comment-14951908
 ] 

Sanjay Patel commented on ATLAS-159:
------------------------------------

[~suma.shivaprasad] We need that empty overlay tag. Overlay works as per first 
win strategy and empty overlay tag represents current build. Current execution 
is like maven war plugin executed first then it will try to execute dashboard 
overlay at that time there is already index.html is present by maven war plugin 
and that index.html is not getting replaced by dashboard overlay[due to first 
win strategy]. dashboard overlay index.html must required as it part of out UI.

Empty overlay tag represents current build.So now with empty overlay tag 
execution is like first dashboard overlay was  getting executed and then maven 
war plugin will be executed so we have our dashboard overlay index.html there 
now.

if you run a build without empty overlay you will not get our UI on 21000 port.

> UI generated files should be target
> -----------------------------------
>
>                 Key: ATLAS-159
>                 URL: https://issues.apache.org/jira/browse/ATLAS-159
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Sanjay Patel
>            Priority: Blocker
>             Fix For: 0.6-incubating
>
>         Attachments: ATLAS-159.v1.patch, ATLAS-159.v2.patch, 
> ATLAS-159.v3.patch
>
>
> All the downloaded/generated files(like folders lib, node, node_modules etc) 
> from UI plugins should be in target so that mvn clean can clean up these 
> files. Build is broken because of this: 
> https://builds.apache.org/job/apache-atlas-nightly/72/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to