[ 
https://issues.apache.org/jira/browse/ATLAS-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009759#comment-15009759
 ] 

Erik Bergenholtz commented on ATLAS-244:
----------------------------------------

Comments on current patch:

* The Add tag button should be "Add Tag" (not mixed case)
* There should be some additional vertical spacing between the bottom edge of 
the button and the top of the table (see http://cl.ly/image/46270c091j3a)
* There is minor line overflow of the "Tags" tab (see 
http://cl.ly/image/46270c091j3a)
* When deleting a tag the trashcan goes away but the the tag is not removed 
from the table
** a deleted tag should be automatically removed from the table
* The tag table should show the name/value pairs so that a user can see the 
value.
** In the future it should be possible to edit/modify the value portion of a 
name/value pair of a tag - so please keep in mind when this screen/table is 
designed. 

> UI: Add Tag Tab
> ---------------
>
>                 Key: ATLAS-244
>                 URL: https://issues.apache.org/jira/browse/ATLAS-244
>             Project: Atlas
>          Issue Type: Improvement
>    Affects Versions: 0.6-incubating
>            Reporter: Erik Bergenholtz
>            Assignee: Rohit
>             Fix For: 0.6-incubating
>
>
> The detailed entity screen needs to add a Tag tab. See: 
> https://monosnap.com/file/en3YL2ARN111d9UDlCozZpBnUhkPwv for additional 
> details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to