[
https://issues.apache.org/jira/browse/ATLAS-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052507#comment-15052507
]
Hemanth Yamijala commented on ATLAS-244:
----------------------------------------
Tested the patch.
* Created tags with more than one attributes. Associated them to an instance
specifying different values - strings, dates etc. Went to the details page of
the attribute, and checked they show up in the tags tab as a comma separated
list.
* Created tags with parent tag and verified the same as above.
* Created tag with no attributes and checked as above. Saw that we are
displaying 'NA' for the attributes value here. I am not sure if this is
appropriate, but will defer for now - we can fix it quickly if required later.
* Created tag with very long attribute name and long attribute value. Checked
how we are displaying and found that we are wrapping the column. So things are
visible and rows become bigger.
* Created tag with attribute name and didn't associate a value when adding. We
are showing this up as 'null' in the view. I am not sure if this is right, but
will defer again - more a requirements question.
Also from a minor comment perspective - we are appending a space around the
comma like this: *attr1:v1 , attr2:value2 something*. Personally, I would
prefer it like this: *attr1:v1, attr2:value2 something* without the leading
space because that's more conventional. Again this is more of a UX question -
we can address this as a fix if required later.
Overall I am +1 based on testing.
> UI: Add Tag Tab
> ---------------
>
> Key: ATLAS-244
> URL: https://issues.apache.org/jira/browse/ATLAS-244
> Project: Atlas
> Issue Type: Improvement
> Affects Versions: 0.6-incubating
> Reporter: Erik Bergenholtz
> Assignee: Darshan Kumar
> Fix For: 0.6-incubating
>
> Attachments: ATLAS-244-v1.patch
>
>
> The detailed entity screen needs to add a Tag tab. See:
> https://monosnap.com/file/en3YL2ARN111d9UDlCozZpBnUhkPwv for additional
> details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
