[
https://issues.apache.org/jira/browse/ATLAS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160239#comment-15160239
]
Hemanth Yamijala commented on ATLAS-476:
----------------------------------------
I have attached a patch on review board requesting review.
[~shwethags], I followed the first approach. However, I did not use the
TransientTypeSystem as you have suggested. There are calls that already rely on
the returned Map of newly added types from {{TypeSystem.defineTypes}} and
{{TypeSystem.updateTypes}}. Rather than change those methods, I instead
extended the same logic to {{TypeStore.store}}.
Since I was added overloaded methods, I tried to cleanup ones that were being
used only in tests etc, particularly in {{TypeStore.store}}.
Let's take the review on the review board and continue discussion there. Thanks.
> Update type attribute with Reserved characters updated the original type as
> unknown
> -----------------------------------------------------------------------------------
>
> Key: ATLAS-476
> URL: https://issues.apache.org/jira/browse/ATLAS-476
> Project: Atlas
> Issue Type: Bug
> Affects Versions: trunk
> Environment: sandbox
> Reporter: Chethana
> Assignee: Hemanth Yamijala
> Priority: Blocker
> Fix For: 0.7-incubating
>
> Attachments: 1.log
>
>
> create a type with required attribute
> try to get this type created - the type data is returned
> try update this type by adding attribute with attribute name consisting of a
> reserved character eg:test$
> this throws exception.
> Now use to get call to get the previously created type
> Expected:
> The type should not be updated.
> Actual:
> "error": "Unknown datatype: className_update_vsvrbzqaqg",
> "stackTrace": "org.apache.atlas.typesystem.exception.TypeNotFoundException:
> Unknown datatype: className_update_vsvrbzqaqg\n\tat
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
