> On May 4, 2016, 3:33 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java, > > line 56 > > <https://reviews.apache.org/r/46943/diff/2/?file=1370654#file1370654line56> > > > > Does it make sense to cache the entities against the GUIDs for longer > > time? Since the flow involves persist to graph, generate fulltext and then > > usually a getEntityDefinition is called on same entity resulting in maping > > the graph to type twice. We could try Titan caching as well?
I understand that this change needs to be extensively tested due to potential memory issues. We could take this up in another jira as well for consideration. - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46943/#review131690 ----------------------------------------------------------- On May 4, 2016, 10:58 a.m., Hemanth Yamijala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46943/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 10:58 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-690 > https://issues.apache.org/jira/browse/ATLAS-690 > > > Repository: atlas > > > Description > ------- > > The patch fixes two regressions caused in Atlas code base recently. > > * A regression involving missing out adding the right indexes > * A regression that caused a quadratic load of vertices for hive objects. > > The first one was fixed by correcting the indexes back. The second one was > fixed by having a per request cache. Some other indexing changes are due to > what looks like a Titan issue. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java > 36d8034 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > d83c08c > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > c542ec7 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > a3dc7e5 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java > 87fdf87 > > Diff: https://reviews.apache.org/r/46943/diff/ > > > Testing > ------- > > * Ran a local run of 1000 hive tables and verified the time taken is as > before the regressions were introduced. > * All existing UTs / ITs pass. New UT for testing index addition added. > > > Thanks, > > Hemanth Yamijala > >
