-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46943/
-----------------------------------------------------------

(Updated May 5, 2016, 4:35 a.m.)


Review request for atlas.


Changes
-------

Addressed latest review comments from Shwetha.


Bugs: ATLAS-690
    https://issues.apache.org/jira/browse/ATLAS-690


Repository: atlas


Description
-------

The patch fixes two regressions caused in Atlas code base recently.

* A regression involving missing out adding the right indexes
* A regression that caused a quadratic load of vertices for hive objects.

The first one was fixed by correcting the indexes back. The second one was 
fixed by having a per request cache. Some other indexing changes are due to 
what looks like a Titan issue.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 
36d8034 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 d83c08c 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
c542ec7 
  
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
 a3dc7e5 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java
 87fdf87 

Diff: https://reviews.apache.org/r/46943/diff/


Testing
-------

* Ran a local run of 1000 hive tables and verified the time taken is as before 
the regressions were introduced.
* All existing UTs / ITs pass. New UT for testing index addition added.


Thanks,

Hemanth Yamijala

Reply via email to