-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47458/
-----------------------------------------------------------

(Updated May 19, 2016, 11:07 a.m.)


Review request for atlas, Erik Bergenholtz, Gautam Borad, Madhan Neethiraj, 
Shwetha GS, and Hemanth Yamijala.


Changes
-------

Apart from favicon 404 issue & (ATLAS-780)

Changes includes.

None security access to api/atlas/status api
Removed display of Username in Header ( as part of feedback from ATLAS-802) 
Commented edit button from Terms edit page (As API for Edit term is not 
available). 

Note :: This patch ATLAS-774.2.patch will work only after applying 
ATLAS-802.6.patch.


Repository: atlas


Description
-------

To post login form via javascript function and to do better error handling pre 
and post submit of login request.
This will help redirecting users to accurate pages based on permissions that 
they have to.

Changes also includes fix for

* favicon 404 issue.
* (ATLAS-780) UI: Atlas UI shows an API response page after login sometimes.


Diffs (updated)
-----

  dashboardv2/public/js/modules/atlasLogin.js PRE-CREATION 
  
dashboardv2/public/js/templates/business_catalog/BusinessCatalogDetailLayoutView_tmpl.html
 PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
383bc3e 
  dashboardv2/public/js/templates/site/header.html fe3803d 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
 PRE-CREATION 
  webapp/src/main/resources/spring-security.xml 4590eef 
  webapp/src/main/webapp/login.jsp 2990477 

Diff: https://reviews.apache.org/r/47458/diff/


Testing
-------

Manual Testing for login related scenerios.
Run mvn clean install.


Thanks,

Nixon Rodrigues

Reply via email to