----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47458/#review134127 -----------------------------------------------------------
Ship it! Ship It! - Shwetha GS On May 19, 2016, 6:31 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47458/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 6:31 p.m.) > > > Review request for atlas, Erik Bergenholtz, Gautam Borad, Madhan Neethiraj, > Shwetha GS, and Hemanth Yamijala. > > > Repository: atlas > > > Description > ------- > > To post login form via javascript function and to do better error handling > pre and post submit of login request. > This will help redirecting users to accurate pages based on permissions that > they have to. > > Changes also includes fix for > > * favicon 404 issue. > * (ATLAS-780) UI: Atlas UI shows an API response page after login sometimes. > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java > PRE-CREATION > webapp/src/main/resources/spring-security.xml 4590eef > webapp/src/main/webapp/login.jsp 2990477 > > Diff: https://reviews.apache.org/r/47458/diff/ > > > Testing > ------- > > Manual Testing for login related scenerios. > Run mvn clean install. > > > Thanks, > > Nixon Rodrigues > >
