> On May 24, 2016, 7:18 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java, > > line 745 > > <https://reviews.apache.org/r/47638/diff/2/?file=1391380#file1391380line745> > > > > can you pls add a test with column position changed as well
I think we already have tests for column position change. Can you please look into the last three tests in testAlterTableChangeColumn in HiveHookIT - Vimal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134617 ----------------------------------------------------------- On May 23, 2016, 6:52 a.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47638/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 6:52 a.m.) > > > Review request for atlas and Shwetha GS. > > > Bugs: ATLAS-752 > https://issues.apache.org/jira/browse/ATLAS-752 > > > Repository: atlas > > > Description > ------- > > ATLAS-752 When a column is renamed, the traits associted with it are lost. > The traits should be retained with the new column > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 418e755 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 70100f1 > > Diff: https://reviews.apache.org/r/47638/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Revised Patch > > https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch > > > Thanks, > > Vimal Sharma > >
