> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, > > line 345 > > <https://reviews.apache.org/r/47638/diff/2-3/?file=1391379#file1391379line345> > > > > its better to load the newTable from metastore here instead of directly > > passing it. The reason is some flags and properties on the table are > > incorrect/incomplete when they are not reloaded from hive metastore? Any > > reason this was done? > > Vimal Sharma wrote: > If we load newTable from Hive metaStore, it will end up creating a new > entity for the table and all its columns. As a result, the traits associated > with the column are lost and the test testTraitsPreservedOnColumnRename() > fails. > > Suma Shivaprasad wrote: > Oh ok. I was a bit confused since we were passing in newTable to the > function. If we intend to create the old state of table, then should we pass > in oldTable(even though it is the same currently but if hive interface > changes and starts passing new column state in newTable, there will be > unexpected issues later on) or is there any issue with that?
Passing oldTable makes sense considering hive interface might change and start passing new column state. Thanks for the observation Suma. I have made the change in the latest patch. - Vimal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134911 ----------------------------------------------------------- On May 26, 2016, 6:04 p.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47638/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 6:04 p.m.) > > > Review request for atlas and Shwetha GS. > > > Bugs: ATLAS-752 > https://issues.apache.org/jira/browse/ATLAS-752 > > > Repository: atlas > > > Description > ------- > > ATLAS-752 When a column is renamed, the traits associted with it are lost. > The traits should be retained with the new column > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 418e755 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 70100f1 > > Diff: https://reviews.apache.org/r/47638/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Revised Patch > > https://reviews.apache.org/media/uploaded/files/2016/05/20/a3ab9b8c-4ffc-4ec6-92d7-1f84db246c6a__ATLAS-752-v3.patch > > > Thanks, > > Vimal Sharma > >
