> On May 26, 2016, 6:04 p.m., Shwetha GS wrote: > > distro/src/conf/hbase_solr-atlas-application.properties, line 2 > > <https://reviews.apache.org/r/47782/diff/2/?file=1395357#file1395357line2> > > > > Instead of adding new files, where configs can go out of sync. Can you > > use single file and use resource filtering to populate the values > > correctly. Have added ATLAS-823-modified.patch on the jira, check if it > > makes sense
Yeah, the replacement values is better. One question with that... since you are specifying the values for both profiles (dist and embedded_services) which one wins if both profiles are used for the build? Should the default values (berkeley, elasticsearch) be specified at a global level and then just overridden for the embedded_services profile? I'll try it out and update the patch. Thanks. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47782/#review135028 ----------------------------------------------------------- On May 26, 2016, 2:17 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47782/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 2:17 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-823 > https://issues.apache.org/jira/browse/ATLAS-823 > > > Repository: atlas > > > Description > ------- > > Use of embedded HBase and SOLR is not preferred due to multiple concerns, > including: > > 1. lack of support by Ambari makes it difficult to handle kerberization, > upgrade/migration, start/stop > 2. not suitable for production use - no HA, local-storage > > Atlas should remove support for embedded HBase and SOLR. Instead Atlas should > be updated to use external HBase and SOLR. > > > Diffs > ----- > > distro/pom.xml 1ab092d > distro/src/bin/atlas_config.py 8f3479c > distro/src/bin/atlas_start.py cb869bb > distro/src/conf/atlas-application.properties 26f84e9 > distro/src/conf/hbase_solr-atlas-application.properties PRE-CREATION > distro/src/conf/hbase_solr-atlas-env.sh PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 09ff47d > docs/src/site/twiki/Configuration.twiki 879c06c > docs/src/site/twiki/InstallationSteps.twiki 006e1e8 > > Diff: https://reviews.apache.org/r/47782/diff/ > > > Testing > ------- > > updated unit test > > mvn clean test > > > Thanks, > > Tom Beerbower > >
