[ 
https://issues.apache.org/jira/browse/ATLAS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303782#comment-15303782
 ] 

Hemanth Yamijala commented on ATLAS-793:
----------------------------------------

I have reviewed the patch attached to review board and raised some comments.

In addition, I tested the patch using the current UI to add & search for terms, 
and a REST client to delete them. A few issues that I see:

* For every GET call made to the term name, I see the following printed in the 
log:
{code}
Query requires iterating over all vertices [()]. For better performance, use 
indexes (StandardTitanTx:1238)
{code}
I don't think this is introduced by the delete patch. Hence, will file a 
separate JIRA for this.

* A couple of times, I saw this line:
{code}
Evicted [23@c0a8010822410-hemanthijalambp-home1] from cache but waiting too 
long for transactions to close. Stale transaction alert on: 
[standardtitantx[null], standardtitantx[null], standardtitantx[null], 
standardtitantx[null], standardtitantx[null], standardtitantx[null], 
standardtitantx[null], standardtitantx[null]] (ManagementLogger:189)
{code}
I did raise a comment on review board about issues with missing to close 
transactions in Titan. I suspect this may be related to changes done in this 
patch. I tried to replicate this by trying out specific scenarios - 
unfortunately, I couldn't do that. I will upload the application.log to the 
file in case it helps (although, it is too verbose to be useful, I suspect).

* Search for entities associated with a tag is using the same search pipeline 
as v1 search for entities, and so may suffer from the same performance 
limitations. Although in this case, I am not entirely sure if search via the v0 
API i.e. ISA DSL search is any more optimized than this. Can try and resolve 
this as part of ATLAS-807.


> Business Catalog Delete
> -----------------------
>
>                 Key: ATLAS-793
>                 URL: https://issues.apache.org/jira/browse/ATLAS-793
>             Project: Atlas
>          Issue Type: Improvement
>    Affects Versions: 0.7-incubating
>            Reporter: Erik Bergenholtz
>            Assignee: John Speidel
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-793.patch
>
>
> Business Catalog API should support deletion of Terms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to