----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48945/#review138569 -----------------------------------------------------------
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java <https://reviews.apache.org/r/48945/#comment203781> I didn't get why this was removed - possibly something specific to Falcon? Likewise, is the USER attribute going to be replaced by OWNER? addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala <https://reviews.apache.org/r/48945/#comment203780> This is removed, but should extend Asset? addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala (line 48) <https://reviews.apache.org/r/48945/#comment203765> description is a part of Asset. So should go, just like owner? - Hemanth Yamijala On June 20, 2016, 9:01 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48945/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 9:01 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-819 > https://issues.apache.org/jira/browse/ATLAS-819 > > > Repository: atlas > > > Description > ------- > > Added base type with the attributes name, owner and description that any > type can extend and the users can set these attributes. > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java > c1ccd05 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 1621d95 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java > 37df6da > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 95f255e > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java > 81cd5e0 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java > c92bd43 > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 8a5736a > > addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala > cf81406 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 3686fa8 > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java > c3bdbfa > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > b2171c2 > > addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala > bae4c1a > client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 > distro/src/conf/atlas-log4j.xml e14afa3 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > dd7dd74 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > c385df3 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > d9e6cb9 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > 9dc93ae > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 0713d30 > webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java > 74d89ce > > Diff: https://reviews.apache.org/r/48945/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > Shwetha GS > >