> On June 20, 2016, 10:19 a.m., Hemanth Yamijala wrote: > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java, > > line 107 > > <https://reviews.apache.org/r/48945/diff/1/?file=1423907#file1423907line107> > > > > I didn't get why this was removed - possibly something specific to > > Falcon? Likewise, is the USER attribute going to be replaced by OWNER?
timestamp was set to current time and didn't have any other significance. Deleted it in favor of atlas system attributes created time and last modified time. user is deleted as owner is set now > On June 20, 2016, 10:19 a.m., Hemanth Yamijala wrote: > > addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala, > > line 51 > > <https://reviews.apache.org/r/48945/diff/1/?file=1423910#file1423910line51> > > > > This is removed, but should extend Asset? Have made fs_path extend dataset and hdfs_path extend fs_path. Will check with Suma once - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48945/#review138569 ----------------------------------------------------------- On June 20, 2016, 9:01 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48945/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 9:01 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-819 > https://issues.apache.org/jira/browse/ATLAS-819 > > > Repository: atlas > > > Description > ------- > > Added base type with the attributes name, owner and description that any > type can extend and the users can set these attributes. > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java > c1ccd05 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 1621d95 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java > 37df6da > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 95f255e > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java > 81cd5e0 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java > c92bd43 > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 8a5736a > > addons/hdfs-model/src/main/scala/org/apache/atlas/fs/model/FSDataModel.scala > cf81406 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > c956a32 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 5d9950f > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 3686fa8 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 5a175e7 > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java > 9db8180 > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/model/SqoopDataModelGenerator.java > c3bdbfa > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > b2171c2 > > addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala > bae4c1a > client/src/main/java/org/apache/atlas/AtlasClient.java 4c88da9 > distro/src/conf/atlas-log4j.xml e14afa3 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > dd7dd74 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > c385df3 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > d9e6cb9 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > 9dc93ae > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 0713d30 > webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java > 74d89ce > > Diff: https://reviews.apache.org/r/48945/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > Shwetha GS > >
