> On Sept. 6, 2016, 11:20 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 296 > > <https://reviews.apache.org/r/51660/diff/2/?file=1492336#file1492336line296> > > > > Is it necessary to create ImmutableList for the values in the argument? > > Please review.
Not using Immutable list after reviewing the use case. > On Sept. 6, 2016, 11:20 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 306 > > <https://reviews.apache.org/r/51660/diff/2/?file=1492336#file1492336line306> > > > > Check if enumDefs is null before using in for(..). > > > > Please review and update other such usage here. Added a guard condition for all the for each loops - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review147940 ----------------------------------------------------------- On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51660/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 11:27 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and > Vimal Sharma. > > > Repository: atlas > > > Description > ------- > > [ATLAS-1098] Added keyword checks while creating a new tag/trait > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 4d05d49 > > Diff: https://reviews.apache.org/r/51660/diff/ > > > Testing > ------- > > Tested with all possible keywords specified in the QueryParser, the UI shows > a red exception message stating that the type being created is a keyword > > > Thanks, > > Apoorv Naik > >
