> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > <https://reviews.apache.org/r/51660/diff/3/?file=1492519#file1492519line309> > > > > This is equals check - typename equals keyword. Does it work if > > typename contains keyword e.g., if typename is 'isa PII'? > > > > Not sure if keywords in DSL is case sensitive. You may want to verify > > Apoorv Naik wrote: > Right now this will go through. > > Apoorv Naik wrote: > I've tried changing the case but seems like the dsl is not case sensitive > for those keywords > > Apoorv Naik wrote: > While testing, I see that if the keyword has any prefix or suffix > separated by a space. The query parser doesn't break. Is that what you're > looking for ? > > Shwetha GS wrote: > You mean DSL is case sensitive for the keywords, so the check need not be > case insensitive? > > Weird that the query "Table isa `isa PII`" works, but "Table isa `isa`" > doesn't work. As David pointed out, its good if we don't add restrictions on > typenames. Can you check queryparser to see if its simple enough fix?
The queries have ` around the typenames with keywords. Formatting removed them - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148651 ----------------------------------------------------------- On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51660/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 11:27 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and > Vimal Sharma. > > > Repository: atlas > > > Description > ------- > > [ATLAS-1098] Added keyword checks while creating a new tag/trait > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 4d05d49 > > Diff: https://reviews.apache.org/r/51660/diff/ > > > Testing > ------- > > Tested with all possible keywords specified in the QueryParser, the UI shows > a red exception message stating that the type being created is a keyword > > > Thanks, > > Apoorv Naik > >
