David, Thanks for validating the release candidate and your comments. Please see my response below:
>> "git clone https://github.com/apache/incubator-atlas.git"; >> This is the wrong git command - as this will put the code into git – not >> clone it from the repository into a local folder. This command gets the repository to local folder “incubator-atlas”, which Is consistent with the following build instructions in the README. >> 2) I think that the readme should explicitly mention the version number >> 0.7.1 and also point to the latest code 0.8 and explicitly talk about the >> need for 0.7.1, rather than using 0.8, which I assume is primarily the >> java level. I think all the urls should default to the latest code (0.8). >> >> 3) I suggest that the readme includes the versions of any libraries that >> need to be on a machine to be able to build. I would mention the required >> levels of Java, Maven, Git and Python. I have not installed as I was not >> sure of the levels I need of these prereqs. Can these be addressed this in the next release? One approach would be to create multiple READM.txt, one for each release. Another approach would be to create multiple sections in README.txt - one for each release. Thanks, Madhan On 1/18/17, 3:18 AM, "David Radley" <[email protected]> wrote: Atlas team, I am not sure if the resdme updates have gone in; from the link below the readme seems not to be correct. I have downloaded the tar.gz file. Readme feedback 1) I notice the readme starts by saying to get the code using "git clone https://github.com/apache/incubator-atlas.git"; This is the wrong git command - as this will put the code into git - not clone it from the repository into a local folder. I look on http://atlas.incubator.apache.org/InstallationSteps.html. It says to use "git clone https://git-wip-us.apache.org/repos/asf/incubator-atlas.git atlas" We need to document a 0.7.1 equivalent for the clone in the readme. 2) I think that the readme should explicitly mention the version number 0.7.1 and also point to the latest code 0.8 and explicitly talk about the need for 0.7.1, rather than using 0.8, which I assume is primarily the java level. I think all the urls should default to the latest code (0.8). 3) I suggest that the readme includes the versions of any libraries that need to be on a machine to be able to build. I would mention the required levels of Java, Maven, Git and Python. I have not installed as I was not sure of the levels I need of these prereqs. The vote will be open for at least 72 hours or until necessary votes are reached. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here is my +1, as long as we address the above points. Thanks, David Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
