----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55912/#review162921 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 73) <https://reviews.apache.org/r/55912/#comment234315> preCreateOrUpdate - if this is not accessed outside this class, consider marking this as 'private'. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 84) <https://reviews.apache.org/r/55912/#comment234317> Consider replacing this line with: AtlasEntityType entityType = typeRegistry.getEntityTypeByName(entity.getTypeName()); repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 214) <https://reviews.apache.org/r/55912/#comment234316> Consider replacing the following lines: AtlasType type = typeRegistry.getType(entity.getTypeName()); if (type.getTypeCategory() != TypeCategory.ENTITY) { throw new AtlasBaseException(AtlasErrorCode.TYPE_MATCH_FAILED, type.getTypeCategory().name(), TypeCategory.ENTITY.name()); } With: AtlasEntityType type = typeRegistry.getEntityTypeByName(entity.getTypeName()); if (type == null) { throw new AtlasBaseException(AtlasErrorCode.TYPE_NAME_INVALID, TypeCategory.ENTITY.name(), entity.getTypeName()); } Please review other such usage of typeRegistry.getType(name) for replacing with typeRegistry.get<entity/struct/classification/enum>TypeByName(name) - Madhan Neethiraj On Jan. 25, 2017, 2:55 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55912/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 2:55 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1498 > https://issues.apache.org/jira/browse/ATLAS-1498 > > > Repository: atlas > > > Description > ------- > > Fixed issues in entity discovery, collections etc found during testing > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e4f3dfd > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 8aba1fb > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4712508 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java f9040f3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > b874c5d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 18e397b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 1947855 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 425bde9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 174e490 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > f942a91 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java > 488f141 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java > 9d219f5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > ae9ecc4 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 0ff33ba > > Diff: https://reviews.apache.org/r/55912/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
