----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55912/#review163118 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java (line 71) <https://reviews.apache.org/r/55912/#comment234571> add @JsonIgnore? intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java (line 80) <https://reviews.apache.org/r/55912/#comment234572> add @JsonIgnore? intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 323) <https://reviews.apache.org/r/55912/#comment234574> This method is no more used elsewhere. Consider marking this as private. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java (line 230) <https://reviews.apache.org/r/55912/#comment234575> Replacing this 'for' with: for (AtlasAttribite attribute : structType.getAllAttributes().values()) { can help eliminate hash table lookups in line #231 and #233. Please review any other such usage as well. - Madhan Neethiraj On Jan. 26, 2017, 4:32 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55912/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 4:32 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1498 > https://issues.apache.org/jira/browse/ATLAS-1498 > > > Repository: atlas > > > Description > ------- > > Fixed issues in entity discovery, collections etc found during testing > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e4f3dfd > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 794310a > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 8aba1fb > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 5ad3a55 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 6e6c522 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4712508 > intg/src/main/java/org/apache/atlas/type/AtlasType.java 6ea34b3 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java f9040f3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/ArrayVertexMapper.java > 528430c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > b874c5d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 18e397b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 1947855 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 425bde9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 3b557e6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 174e490 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > f942a91 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphMutationContext.java > d5ba7e1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java > 488f141 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java > 9d219f5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > ae9ecc4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java > 8025f1e > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 0ff33ba > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > 74ab740 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 2b13552 > > Diff: https://reviews.apache.org/r/55912/diff/ > > > Testing > ------- > > All tests till webapp are passing. In webapp , UTs are failing which need to > be fixed > > Failed tests: > TestEntitiesREST.testCreateOrUpdateEntities:105 ยป AtlasBase expected type > Map ... > TestEntityREST.testGetEntityById:97 expected:<false> but was:<null> > TestEntityREST.testUpdateGetDeleteEntityByUniqueAttribute:171 > expected:<false> but was:<null> > > > Thanks, > > Suma Shivaprasad > >
