----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58750/#review173322 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 55 (patched) <https://reviews.apache.org/r/58750/#comment246336> I am not sure if I have understood this correctly. It seems that here is a a configuration option that when set will allow attributes to be defined with the query keywords. I assume if the config utation option is then switched off, then Atlas will need to deal with / delete any now invalid entities. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java Lines 61 (patched) <https://reviews.apache.org/r/58750/#comment246337> It looks like we support attribute names with spaces in. Do we need to make sure that there is not a keyword as a substring word for example "has a" contains keyword has? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java Lines 67 (patched) <https://reviews.apache.org/r/58750/#comment246338> I suggest logging the real Exception here. repository/src/main/scala/org/apache/atlas/query/QueryParser.scala Lines 426 (patched) <https://reviews.apache.org/r/58750/#comment246339> Is this called? - David Radley On April 26, 2017, 8:37 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58750/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 8:37 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1744 > https://issues.apache.org/jira/browse/ATLAS-1744 > > > Repository: atlas > > > Description > ------- > > Added validation to reject type creations with attributes having reserved > keywords with a configuration to override this behaviour > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 62fe9ac > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java eca1abf > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > ce29f8d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java > 8144ddf > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > d94aa21 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java > 096f99b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java > a79b6c5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > f154555 > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 803b702 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > 120187d > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58750/diff/1/ > > > Testing > ------- > > Added UTS for both > > 1.Testing Rejection of type creations with attributes having reserved > keywords with a configuration to override this behaviour > 2.testing search with escape quotes > > > Thanks, > > Suma Shivaprasad > >
