----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58750/#review173423 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 29, 2017, 7:14 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58750/ > ----------------------------------------------------------- > > (Updated April 29, 2017, 7:14 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1744 > https://issues.apache.org/jira/browse/ATLAS-1744 > > > Repository: atlas > > > Description > ------- > > Added validation to reject type creations with attributes having reserved > keywords with a configuration to override this behaviour > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java > dde263b > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala d9fd865 > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java > 9f69e5b > > > Diff: https://reviews.apache.org/r/58750/diff/2/ > > > Testing > ------- > > Added UTS for both > > 1.Testing Rejection of type creations with attributes having reserved > keywords with a configuration to override this behaviour > 2.testing search with escape quotes > > > Thanks, > > Suma Shivaprasad > >
