----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59769/#review178329 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java Lines 127 (patched) <https://reviews.apache.org/r/59769/#comment252220> Consider returning void from 'delete'. - Madhan Neethiraj On June 19, 2017, 6:53 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59769/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 6:53 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, and Suma Shivaprasad. > > > Bugs: ATLAS-1856 > https://issues.apache.org/jira/browse/ATLAS-1856 > > > Repository: atlas > > > Description > ------- > > Based on the relationDef implementation in ATLAS-1852. Implement instance API > and REST for entity relationships. This patch is not complete. > work in progress > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java > deccf843 > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > 93d988e6 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > 7ef49e66 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > bd7b35e4 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java > 662a2705 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java > 056088cf > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java > 5ad176b5 > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > e829d918 > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java > 9dc175b6 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f402 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java > 000d747b > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java aebd4d1a > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ca7fad06 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 560b3385 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 66f20daa > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7a064b60 > repository/src/test/java/org/apache/atlas/TestModules.java 095af417 > webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59769/diff/4/ > > > Testing > ------- > > Tested using POSTMAN. UTs and ITs in progress. > > > Thanks, > > Sarath Subramanian > >
