> On June 20, 2017, 2:51 a.m., David Radley wrote: > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > > Line 408 (original), 403 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753841#file1753841line408> > > > > I am wondering what the intent is here- please could you add a comment?
We have APIs only to issue graph query and retrieve vertices, this change is about returning edges() in graph query result. (used to retrieve relationship using guid) > On June 20, 2017, 2:51 a.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > > Lines 227 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753844#file1753844line227> > > > > Should relationship equals only check the structural parts. Not > > createdBy , updatetime etc. relationship equals was made consistent with AtlasStruct equals(). If the structural parts are same (guid, end1, end2) then the created time, updateTime will also be same. > On June 20, 2017, 2:51 a.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > > Lines 60 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753847#file1753847line60> > > > > can relationshipDef be null here? removed this check. > On June 20, 2017, 2:51 a.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > > Lines 63 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753847#file1753847line63> > > > > if an end type is null -shouldn't we stop any firther processing in > > this method. if end type is null, exception will be thrown from line 69 and 75 (will fail instanceof check) > On June 20, 2017, 2:51 a.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > > Lines 66 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753847#file1753847line66> > > > > Rather than use reflection I suggest checking the category using > > getTypeCategory. this check is made to be consistent with other classes where we make similar checks in AtlasEntity, AtlasClassification. > On June 20, 2017, 2:51 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 101 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753852#file1753852line101> > > > > So we create the first edge of the relationship and then additional > > legacy edges. Will any legacy implmnetations be effected by the new edge? No legacy implementation will not be affected. This checks if a leagacy edge already exists, if not go aheads and creates one. > On June 20, 2017, 2:51 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 106 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753852#file1753852line106> > > > > I am not sure this is right. It is valid to have more than one > > relationship between 2 entities. It is valid to have more than one relationship between 2 entities, but only one relationship between two entity attributes. my_table(columns - attr) --> my_column(table - attr) > On June 20, 2017, 2:51 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 197 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753852#file1753852line197> > > > > in the Def code there is a get method that then works out if it needs > > to do a getbyName or get bu Guid. I suggest following the same pattern. This is a firstcut implementation, this will be added along with update and delete operations. > On June 20, 2017, 2:51 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 301 (patched) > > <https://reviews.apache.org/r/59769/diff/6/?file=1753852#file1753852line301> > > > > where do we add the relationship attributes ? The relationshiop attributes are added to the edge in line 91 - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59769/#review178356 ----------------------------------------------------------- On June 19, 2017, 6:55 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59769/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 6:55 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, and Suma Shivaprasad. > > > Bugs: ATLAS-1856 > https://issues.apache.org/jira/browse/ATLAS-1856 > > > Repository: atlas > > > Description > ------- > > Based on the relationDef implementation in ATLAS-1852. Implement instance API > and REST for entity relationships. This patch is not complete. > work in progress > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java > deccf843 > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > 93d988e6 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > 7ef49e66 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > bd7b35e4 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java > 662a2705 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java > 056088cf > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java > 5ad176b5 > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > e829d918 > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java > 9dc175b6 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f402 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java > 000d747b > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0ff15827 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > eb2fc48b > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java aebd4d1a > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ca7fad06 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 560b3385 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 66f20daa > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7a064b60 > repository/src/test/java/org/apache/atlas/TestModules.java 095af417 > webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59769/diff/6/ > > > Testing > ------- > > Tested using POSTMAN. UTs and ITs in progress. > > > Thanks, > > Sarath Subramanian > >
