----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30649 -----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58739> I'm still not keen on using the map view as the facade to the cache. Any reason to not use Cache directly? src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58740> Seems like the baked-in SystemRandom would impede testability. Any reason to not accept the Random? src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58741> s/Long/long/ Subtle difference, but long makes it impossible for the caller to get null. Alternatively — why not just return Amount? As it stands, the method name hides the unit. So at the very least it should have "Ms" on the end, but at that point i suggest just returning Amount<Long, Time>. src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58742> ditto: s/Integer/int/ - Bill Farner On Dec. 18, 2013, 5:54 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16247/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 5:54 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Modified PulseMonitor to support random initial jitter delay. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java > e31ce3d71c895f43ff73ad8e904124443ebdd72a > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java > 44aeadcbcbc35098ed9271269c43884c5cbdc752 > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java > 5a8e13f0d719052286a7136707d7ed1aca87bab2 > > src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java > ac5e3102925e2f26a12e18e95817403d18e25cb3 > > Diff: https://reviews.apache.org/r/16247/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
