----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30661 -----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58756> No particular reason apart from a more familiar interface. Changed to Cache. src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58753> I am exposing it through the getDelayMs() and the GcExecutorSettings gets mocked out in tests. I could inject an interface for the Random but it would not add any value. src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58754> Done. src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58755> Done. - Maxim Khutornenko On Dec. 19, 2013, 12:44 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16247/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 12:44 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Modified PulseMonitor to support random initial jitter delay. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java > e31ce3d71c895f43ff73ad8e904124443ebdd72a > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java > 44aeadcbcbc35098ed9271269c43884c5cbdc752 > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java > 5a8e13f0d719052286a7136707d7ed1aca87bab2 > > src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java > ac5e3102925e2f26a12e18e95817403d18e25cb3 > > Diff: https://reviews.apache.org/r/16247/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
