----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/166/#review186 -----------------------------------------------------------
trunk/lang/py/src/avro/schema.py <http://review.hbase.org/r/166/#comment861> I think this is the problem spot? That is, we store full name as object property, which I did for convenience. If this Schema is printed it won't match the original schema definition. For instance, implicit namespaces will be converted to fully qualified names... is that the problem? - Patrick On 2010-06-10 22:28:05, Jeff Hammerbacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/166/ > ----------------------------------------------------------- > > (Updated 2010-06-10 22:28:05) > > > Review request for Avro. > > > Summary > ------- > > Most recent patch that went into trunk. Let's figure out how to make it > better at schema printing and add some tests. > > > This addresses bug AVRO-284. > http://issues.apache.org/jira/browse/AVRO-284 > > > Diffs > ----- > > trunk/lang/py/src/avro/protocol.py 953187 > trunk/lang/py/src/avro/schema.py 953187 > trunk/lang/py/test/test_protocol.py 953187 > trunk/lang/py/test/test_schema.py 953187 > > Diff: http://review.hbase.org/r/166/diff > > > Testing > ------- > > > Thanks, > > Jeff > >
