----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/166/#review206 -----------------------------------------------------------
trunk/lang/py/src/avro/schema.py <http://review.hbase.org/r/166/#comment935> Also, don't use getters/setters in Python. Look for a # read-only properties comment to see how this is done. trunk/lang/py/src/avro/schema.py <http://review.hbase.org/r/166/#comment934> Actually, here is the issue: set_prop is used to add properties for printing. You should add read-only parameters for member variables that don't get printed rather than using set_prop. - Jeff On 2010-06-10 22:28:05, Jeff Hammerbacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/166/ > ----------------------------------------------------------- > > (Updated 2010-06-10 22:28:05) > > > Review request for Avro. > > > Summary > ------- > > Most recent patch that went into trunk. Let's figure out how to make it > better at schema printing and add some tests. > > > This addresses bug AVRO-284. > http://issues.apache.org/jira/browse/AVRO-284 > > > Diffs > ----- > > trunk/lang/py/src/avro/protocol.py 953187 > trunk/lang/py/src/avro/schema.py 953187 > trunk/lang/py/test/test_protocol.py 953187 > trunk/lang/py/test/test_schema.py 953187 > > Diff: http://review.hbase.org/r/166/diff > > > Testing > ------- > > > Thanks, > > Jeff > >
