[
https://issues.apache.org/jira/browse/AVRO-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885864#action_12885864
]
Jeff Hammerbacher edited comment on AVRO-544 at 7/7/10 3:27 AM:
----------------------------------------------------------------
Okay, here's a patch that factors start() out of the ctor as well, and changes
all of the users of the ctor as well. Note that exposing start() should allow
us to make TestStatsPluginAndServlet.java less hacky (e.g. only start one
server), but I'll leave that for those who know Java better than me.
Also, I note that DatagramServer and SocketServer both implement the Server
interface, so they should probably override start() as well. Given that they
are deprecated, and they don't currently use the @Override annotation on
close() either, I didn't bother to change them.
Lastly, why do we use close()? Jetty uses stop(), and that seems like the
logical thing for Avro servers to implement as well.
was (Author: hammer):
Okay, here's a patch that factors start() out of the ctor as well, and
changes all of the calling applications. Note that exposing start() should
allow us to make TestStatsPluginAndServlet.java less hacky (e.g. only start one
server), but I'll leave that for those who know Java better than me.
Also, I note that DatagramServer and SocketServer both implement the Server
interface, so they should probably override start() as well. Given that they
are deprecated, and they don't currently use the @Override annotation on
close() either, I didn't bother to change them.
Lastly, why do we use close()? Jetty uses stop(), and that seems like the
logical thing for Avro servers to implement as well.
> Allow the HttpServer to serve forever without a call to Thread.sleep()
> ----------------------------------------------------------------------
>
> Key: AVRO-544
> URL: https://issues.apache.org/jira/browse/AVRO-544
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Jeff Hammerbacher
> Assignee: Jeff Hammerbacher
> Fix For: 1.4.0
>
> Attachments: AVRO-544-2.patch, AVRO-544-3.patch, AVRO-544.patch
>
>
> One way would be to expose the join() method on the HttpServer:
> http://jetty.codehaus.org/jetty/jetty-6/apidocs/org/mortbay/jetty/Server.html#join%28%29
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
