[
https://issues.apache.org/jira/browse/AVRO-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886156#action_12886156
]
Philip Zeyliger commented on AVRO-544:
--------------------------------------
Took a look via reviewboard:
The code, besides the catch (Exception e), looks fine.
I do worry that this is a massively backwards-incompatible change. Anyone
who's set up an Avro RPC server using HttpServer now needs to add a line to
their code. I can only think of hacky ways around that.
trunk/lang/java/src/java/org/apache/avro/ipc/HttpServer.java
<http://review.hbase.org/r/281/#comment1391>
I would add to the java doc that this throws AvroRuntimeException.
trunk/lang/java/src/java/org/apache/avro/ipc/HttpServer.java
<http://review.hbase.org/r/281/#comment1392>
catch (Exception e) is poor form, typically. It's usually better to
explicitly catch the type of exception that Jetty's start throws.
- Philip
> Allow the HttpServer to serve forever without a call to Thread.sleep()
> ----------------------------------------------------------------------
>
> Key: AVRO-544
> URL: https://issues.apache.org/jira/browse/AVRO-544
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Jeff Hammerbacher
> Assignee: Jeff Hammerbacher
> Fix For: 1.4.0
>
> Attachments: AVRO-544-2.patch, AVRO-544-3.patch, AVRO-544.patch
>
>
> One way would be to expose the join() method on the HttpServer:
> http://jetty.codehaus.org/jetty/jetty-6/apidocs/org/mortbay/jetty/Server.html#join%28%29
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
