[
https://issues.apache.org/jira/browse/AVRO-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896639#action_12896639
]
Patrick Wendell commented on AVRO-606:
--------------------------------------
{quote}
this.spansSoFar -= spansPerFile.get(oldest);
Is this always the same as this.spansSoFar = 0?
{quote}
No. spansSoFar tracks spans stored in *all files* which is what the limit
applies to. So this is just subtracting the spans of the most recently deleted
file.
bq.Wouldn't you want to set spansSoFar to 0 if you're writing a new file?
Same answer.
{quote}
Boolean writerEnabled;
Why not primitive type?
{quote}
This is passed by reference to the thread so that the parent thread can signal
the child to stop if it wishes. Is there a better way to do this?
{quote}
@param start UNIX time (in nanoseconds) as a long
Huh? I thought this was millis/1000, i.e., seconds and not nanos.
{quote}
I changed from milli to nanoseconds to support implementations which have
better clock granularity. Currently I don't think any systems offer granularity
better than microseconds (1*10^-6) but don't see any reason not to be more
specific if there is no additional overhead.
> Add File-Based Span Storage to TracePlugin
> ------------------------------------------
>
> Key: AVRO-606
> URL: https://issues.apache.org/jira/browse/AVRO-606
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-606.v1.txt, AVRO-606.v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
