[
https://issues.apache.org/jira/browse/AVRO-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897386#action_12897386
]
Philip Zeyliger commented on AVRO-606:
--------------------------------------
Looks good.
I don't see "writerEnabled" being used, except to set it to true once. Am I
missing something? You probably need a volatile for it. I tend to use methods
instead of fields for this sort of control (disableWriter() or what-not), so as
to abstract away the implementation.
-- Philip
> Add File-Based Span Storage to TracePlugin
> ------------------------------------------
>
> Key: AVRO-606
> URL: https://issues.apache.org/jira/browse/AVRO-606
> Project: Avro
> Issue Type: Sub-task
> Reporter: Patrick Wendell
> Assignee: Patrick Wendell
> Attachments: AVRO-606.v1.txt, AVRO-606.v2.txt, AVRO-606.v3.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
