[
https://issues.apache.org/jira/browse/AVRO-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901106#action_12901106
]
Jeremy Custenborder commented on AVRO-533:
------------------------------------------
Hey Thiru,
The main point in me putting out this patch was so that there are a few other
corporate devs that have been in contact with me about my fork. This is an
initial contribution and is not completely working release. Jeff Hammerbacher
asked me to create a patch of what I have done so far. This is what that patch
is.
{quote}Most of the tests passed on my machine, some failed. One test even
crashes NTest UI.{quote}
I'm aware of that. Schema parsing still needs some work. Testing the interop
schema causes a stack overflow.
{quote}It's not clear why only NullSchema and BooleanSchema are specified and
the rest of the primitive schemas are left alone. I think a a more appropriate
hierarchy would be:{quote}
At one point I had a schema definition for all of the primitive types. I
removed all of these for just using the static variable Primitive.Boolean,
Primitive.Null. I forgot to remove the NullSchema and BooleanSchema classes.
These should be removed.
{quote}Instead of having SchemaType as a string, it'd be better to have it as
an enum, which, unlike string, is close-ended.{quote}
This was my first approach but I ended up moving away from the enum. For the
life of me I cannot remember why.
{quote}Testing appears inadequate. In TestSchema, for example the test only
covers parsing.{quote}
Yep it's not a full release. It's only what I have finished so far. You are
welcome to add tests.
{quote}I see some files have both Windows and Unix line-endings. I don't know
where the problem is. Do you think keeping Windows line-ending throughout will
keep us from these troubles?{quote}
This must have been my git settings on windows. Do you want me to try and
correct it then resubmit?
{quote}I tired to capture all the above ideas (regarding the Schema not
encoder/decoder) by refactoring the code. I kept it at
[email protected]:thirumg/Avro.NET.git in the master branch.
Please feel free to pull it and try. I have commented out certain tests and
code in Avrogen because of this refactroing. Please don't mistake me, my
intention was not to arbitrarily change your code. I thought some ideas are
better shown by demonstration rather than pages and pages of text.{quote}
Instead of commenting out the tests lets put the Explicit argument on them.
This will allow the tests to be executed if you explicitly execute the test. If
you execute all of the tests, Explicit tests will be skipped.
Changing the code does not bother me. The main reason I put this patch together
is that I have been contacted by interested parties that due to corporate legal
concerns needed the code to be submitted to ASF before they could add their
contributions.
{quote}Do you have any suggestion for a code coverage tool? It'll be nice to
know how much coverage we get with our tests.{quote}
ncover?
> .NET implementation of Avro
> ---------------------------
>
> Key: AVRO-533
> URL: https://issues.apache.org/jira/browse/AVRO-533
> Project: Avro
> Issue Type: New Feature
> Affects Versions: 1.4.0
> Reporter: Jeff Hammerbacher
> Attachments: AVRO-533.zip, dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
