[ 
https://issues.apache.org/jira/browse/AVRO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906168#action_12906168
 ] 

Doug Cutting commented on AVRO-641:
-----------------------------------

Thanks for the comments, Aaron.  As you know, I copied much of the 
implementation here from your Thrift implementation.  Thanks for that too!

Based on your feedback, I intend to improve correctness of the SASL 
implementation by:
 - add a status code to each message (as you've done for Thrift)
 - add the SASL mechanism name to the first, status=START message (as you 
suggest)

Further, things can be optimized in at least a few places:
 - I am double-framing the payload data and think I can eliminate that.
 - writes can be gathered, to use fewer system calls & packets

Finally I need to add some documentation before this can be committed.

> add SASL to socket transport
> ----------------------------
>
>                 Key: AVRO-641
>                 URL: https://issues.apache.org/jira/browse/AVRO-641
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-641.patch, AVRO-641.patch, AVRO-641.patch, 
> AVRO-641.patch, AVRO-641.patch
>
>
> Java's socket transport is non-standard (not in the Avro spec) but might 
> serve as a prototype of a future standard transport (AVRO-341).
> It would be useful to extend it to support SASL-based authentication and 
> encryption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to