[
https://issues.apache.org/jira/browse/AVRO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910776#action_12910776
]
Aaron T. Myers commented on AVRO-641:
-------------------------------------
In case it wasn't clear, +1.
bq. Java fields, unlike variables, always have a default value. The default for
a boolean is false.
Sure, I just think it's better to be explicit. The only thing you lose is 8
characters in the .java file.
bq. UTF-8 and ASCII encode the characters permitted in mechanism names
identically. But specifying UTF-8 is confusing, so I've removed that from the
document.
Certainly true that there's no difference in encoding, but allowing arbitrary
UTF-8 mechanism names is overly-broad. In fact, allowing arbitrary ASCII would
be overly-broad. I think it's wise to remove the mention of how mechanism names
are encoded, since there's no need to reproduce the SASL specification in this
document.
bq. I slightly prefer to leave the mechansim length at 4-bytes, since it
simplifies implementation.
Totally agree. Just pointing it out, in case you were concerned about
compactness.
bq. I believe that when one side sends COMPLETE the other side does not
respond, that a single COMPLETE terminates negotiation.
Upon further review, I agree with you.
bq. I wonder where that strange text came from?
Quite curious indeed.
> add SASL to socket transport
> ----------------------------
>
> Key: AVRO-641
> URL: https://issues.apache.org/jira/browse/AVRO-641
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.4.1
>
> Attachments: AVRO-641.patch, AVRO-641.patch, AVRO-641.patch,
> AVRO-641.patch, AVRO-641.patch, AVRO-641.patch, AVRO-641.patch
>
>
> Java's socket transport is non-standard (not in the Avro spec) but might
> serve as a prototype of a future standard transport (AVRO-341).
> It would be useful to extend it to support SASL-based authentication and
> encryption.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
