[
https://issues.apache.org/jira/browse/AVRO-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983914#action_12983914
]
Doug Cutting commented on AVRO-716:
-----------------------------------
Looks great, Scott!
A few things I noticed:
- perhaps we should create a lang/java/build.sh that contains the logic for
each of the top-level targets, so that the top-level just has something simple
like '(cd lang/java; ./build.sh dist)'?
- i just realized that all of the pom.xml files have the version
(1.5.0-SNAPSHOT) duplicated. prior to the switch to maven, the Avro version
was only in a single place, share/VERSION.txt at the top-level. perhaps
lang/java/build.sh could invoke 'mvn -Davro.version=`cat
../../share/VERSION.txt`', and the pom.xml files could be changed to refer to
$avro.version? that would mean that running 'mvn' from the command line might
not work though. or maybe we could use the maven properties plugin to have all
of the poms read from a common properties file that's generated from
share/VERSION.txt...
> New Java build: integrate with parent build and remove cruft
> ------------------------------------------------------------
>
> Key: AVRO-716
> URL: https://issues.apache.org/jira/browse/AVRO-716
> Project: Avro
> Issue Type: Task
> Components: build, java
> Reporter: Scott Carey
> Assignee: Scott Carey
> Priority: Blocker
> Fix For: 1.5.0
>
> Attachments: AVRO-716.v1.patch
>
>
> We have legacy ant and ivy items in lang/java that need to be removed or
> reduced.
> 'ant clean' 'and compile' and 'ant test' can simply forward to maven, we
> might still want to have ant drive interop tests, and it is useful to have
> ant around as a tool.
> Additionally, buildbot currently fails and build.sh from the top level does
> not properly build Java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
