[
https://issues.apache.org/jira/browse/AVRO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998011#comment-12998011
]
Scott Carey commented on AVRO-726:
----------------------------------
Its because we have some more discussion/documenation before there is consensus
and this does not break API. We could get 1.5.1 out relatively fast if there
is demand for it. Also, if there are delays in 1.5.0 this could still slip
back in, but it is not blocking the release.
Questions:
* Would a protected setter/getter work for you? That would expose less of the
internals than a protected member variable.
* Is it OK if the field is final? One of the two was final before, and if they
both can be, then only a getter is necessary.
> Make GenericDatumReader/GenericDatumWriter data member protected so that it
> can be used by the derived classes
> --------------------------------------------------------------------------------------------------------------
>
> Key: AVRO-726
> URL: https://issues.apache.org/jira/browse/AVRO-726
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.5.0
> Reporter: Xiaolu Ye
> Assignee: Scott Carey
> Fix For: 1.5.1
>
> Attachments: AVRO-726.1.patch
>
>
> Currently, GenericDatumReader/GenericDatumWriter data members are private. Is
> it possible to make them protected so that we could extend those classes and
> create our own special DatumReader/Writer? The reason we want to do that is
> because we've created our own base SpecificRecordEx that implements
> SpecificRecord and added put/get for primitive types. We now want to extend
> the GenericDatumReader/GenericDatumWriter to use those primitive put/get
> functions to reduce box/unbox for better performance.
> Thanks,
> Xiaolu
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
