[
https://issues.apache.org/jira/browse/AVRO-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045355#comment-13045355
]
Doug Cutting commented on AVRO-539:
-----------------------------------
Looking good! A few comments and questions:
- the flag might better be named 'generateCallbacks' than
'generateClientInterface'.
- can we make this flag optional? it would be nice if we don't incompatibly
change so many public methods and the command line interface.
- maybe instead of generating another file, we could generate a nested
interface? e.g., {code}
public interface Foo {
int x();
public interface Callbacks extends Foo {
void x(Callback<Integer> callback);
}
}{code}
- i don't think we need guards around log.debug statements that are passed a
constant string. and if the log strings are constructing then it's efficient
with slf4j to use a format string, e.g., log.debug("Error in x: {}", e);
- can Request, Response and RequestorTranscieverCallback be private or
package-private?
Also, I will be mostly offline for the next week and may not be able to review
patches very quickly.
> Allow asynchronous clients to specify a callback to be run when server
> processing completes
> -------------------------------------------------------------------------------------------
>
> Key: AVRO-539
> URL: https://issues.apache.org/jira/browse/AVRO-539
> Project: Avro
> Issue Type: New Feature
> Reporter: Jeff Hammerbacher
> Attachments: AVRO-539-v2-2.patch, AVRO-539-v2.patch, AVRO-539.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
