[ 
https://issues.apache.org/jira/browse/AVRO-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555456#comment-13555456
 ] 

Mark Wagner commented on AVRO-1229:
-----------------------------------

Is the expectation that all sequences of calls to write/readBoolean() will be 
followed by a call to write/readLength()? The calls to readInt and writeInt 
that are used now will need to be switched over, right?

There seems to be an issue where when writing, that bits are written from the 
end and shifted left (i.e., true, false, true gives 0000 0101 instead of 1010 
0000). I've attached a patch for this and changed the tests so COUNT%8 != 0
                
> Trevni should support Boolean fields
> ------------------------------------
>
>                 Key: AVRO-1229
>                 URL: https://issues.apache.org/jira/browse/AVRO-1229
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Mark Wagner
>            Assignee: Doug Cutting
>             Fix For: 1.7.4
>
>         Attachments: AVRO-1229.1.patch, AVRO-1229.patch, AVRO-1229.patch
>
>
> Trevni currently provides no native support for Boolean types. As part of the 
> Avro support, Booleans should be available. The Impala code recognizes this 
> as well: 
> https://github.com/cloudera/impala/blob/master/be/src/exec/trevni-def.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to