[ 
https://issues.apache.org/jira/browse/AVRO-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555484#comment-13555484
 ] 

Doug Cutting commented on AVRO-1229:
------------------------------------

> Is the expectation that all sequences of calls to write/readBoolean() will be 
> followed by a call to write/readLength()?

No, rather those are the only other calls that are ever intermixed with 
read/writeBoolean().  Column buffers contain either entirely instances of the 
same scalar type (boolean in this case) or, in the case of an array of scalars, 
they have length-prefixed sequences of scalars.

The API could be improved to enforce this.  We should perhaps instead have 
something like OutputBuffer<T> with just two methods, write(T) and 
writeLength(int), then a factory that returns different implementations for 
different types.  Regardless, lengths are the only type that's ever intermixed 
with other types.
                
> Trevni should support Boolean fields
> ------------------------------------
>
>                 Key: AVRO-1229
>                 URL: https://issues.apache.org/jira/browse/AVRO-1229
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Mark Wagner
>            Assignee: Doug Cutting
>             Fix For: 1.7.4
>
>         Attachments: AVRO-1229.1.patch, AVRO-1229.patch, AVRO-1229.patch
>
>
> Trevni currently provides no native support for Boolean types. As part of the 
> Avro support, Booleans should be available. The Impala code recognizes this 
> as well: 
> https://github.com/cloudera/impala/blob/master/be/src/exec/trevni-def.h

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to