[ 
https://issues.apache.org/jira/browse/AVRO-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758038#comment-13758038
 ] 

Sean Busbey commented on AVRO-1063:
-----------------------------------

The main issue is that a patch was never submitted here on the Jira. The [how 
to contribute 
page|https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute] has 
moved since Doug's comment on the pull request, but the core content should 
still be the same. An important part of patch submission via the Apache jira 
vice a github pull request is the assignment of licensing to the ASF. Without 
this, we can't use contributions.

Additionally, it's easier to review patches if the submitter creates a [review 
board|https://reviews.apache.org/] entry for it when asking for a review.

I'm not a committer to Avro, but I am a long time user, a contributor, and a 
lover of Ruby. I've already had to wrap the Java Avro libraries myself to use 
JRuby, so I'd love to see this committed. I can happily provide a non-binding 
review if [~pdlug] can submit the patch here. That should help move things 
along.
                
> Ruby client should use multi_json rather than being locked down to yajl
> -----------------------------------------------------------------------
>
>                 Key: AVRO-1063
>                 URL: https://issues.apache.org/jira/browse/AVRO-1063
>             Project: Avro
>          Issue Type: Improvement
>          Components: ruby
>            Reporter: Paul Dlug
>            Priority: Minor
>
> The avro ruby client uses yajl for JSON serialization which is just one of 
> many suitable JSON implementations for ruby. The multi_json gem provides a 
> wrapper for JSON serialization selecting the fastest library available (Oj is 
> now even faster than Yajl) and falling back to a pure ruby implementation 
> bundled with multi_json. Requiring yajl also precludes the ruby gem from 
> being used under jruby since it requires a C extension.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to