[
https://issues.apache.org/jira/browse/AVRO-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781273#comment-13781273
]
Sean Busbey commented on AVRO-1063:
-----------------------------------
Overall looks good. I haven't gotten to run the tests with MRI yet; I should be
able to do that next week.
* Please fix: we should specify a version of multi-json for the dependency. Per
the guidance from multijson, that version should be pessimistic, i.e. ~> 1.8
(presuming you tested with 1.8)
* Nit: whitespace changes on some Apache headers are unnecessary
On compatibility, this *should* be compatible, but there could be edge cases
where some different behavior happens due to the JSON parsers installed in some
client system. I don't know of any amongst the ruby libraries, but I have run
into differences between the python library compared to the java library (the
java library ignored an error in some schema json that the python library did
not).
[~cutting], how strict do you want to be on this? We could try to rule out
obvious issues by adding some tests that compare parsings for some schemas (and
I guess JSON encoded avro) amongst Yajl and the other backends (or a subset of
them).
> Ruby client should use multi_json rather than being locked down to yajl
> -----------------------------------------------------------------------
>
> Key: AVRO-1063
> URL: https://issues.apache.org/jira/browse/AVRO-1063
> Project: Avro
> Issue Type: Improvement
> Components: ruby
> Reporter: Paul Dlug
> Priority: Minor
> Fix For: 1.7.6
>
> Attachments: AVRO-1063.diff
>
>
> The avro ruby client uses yajl for JSON serialization which is just one of
> many suitable JSON implementations for ruby. The multi_json gem provides a
> wrapper for JSON serialization selecting the fastest library available (Oj is
> now even faster than Yajl) and falling back to a pure ruby implementation
> bundled with multi_json. Requiring yajl also precludes the ruby gem from
> being used under jruby since it requires a C extension.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
