[
https://issues.apache.org/jira/browse/AVRO-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891047#comment-13891047
]
Doug Cutting commented on AVRO-1443:
------------------------------------
This patch has a lot of cosmetic changes, many in code that's otherwise not
changed. It removes end-of-line spaces, changes the order of imports,
reformats code, adds redundant @inheritDoc tags, adds section-heading comments,
etc. These might all be fine changes, but they make it much more difficult for
me to review the patch's functional changes, since I cannot focus on them. I
much prefer cosmetic changes as separate patches. If an IDE is automatically
making some of these changes for you then I encourage you to reconfigure the
IDE.
It appears that this change is incompatible since it will require
re-compilation rather than simply a jar update. Is that right? If so, then we
should include it in 1.8.0, not 1.7.7.
> SpecificRecord builders should share more functionality with GenericRecord
> builders
> -----------------------------------------------------------------------------------
>
> Key: AVRO-1443
> URL: https://issues.apache.org/jira/browse/AVRO-1443
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.5, 1.7.6
> Reporter: Christophe Taton
> Assignee: Christophe Taton
> Attachments: AVRO-1443.20140126-182111-0800.diff,
> AVRO-1443.20140202-182611-0800.svndiff
>
>
> Ideally, wherever a generic record builder is expected, one should be able to
> supply a builder for a specific record.
> That could happen by making SpecificRecordBuilderBase (and
> SpecificErrorBuilderBase?) a subclass of GenericRecordBuilder.
> Since SpecificRecordBase implements GenericRecord, it should be possible with
> minimal effort.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
