[
https://issues.apache.org/jira/browse/AVRO-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891197#comment-13891197
]
Doug Cutting commented on AVRO-1443:
------------------------------------
A separate change with cosmetic changes would be better. Thanks!
Does /** {@inheritDoc} */ actually change anything? The javadoc is already
inherited, no?
I'll try to make a more detailed review ASAP.
> SpecificRecord builders should share more functionality with GenericRecord
> builders
> -----------------------------------------------------------------------------------
>
> Key: AVRO-1443
> URL: https://issues.apache.org/jira/browse/AVRO-1443
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.5, 1.7.6
> Reporter: Christophe Taton
> Assignee: Christophe Taton
> Attachments: AVRO-1443.20140126-182111-0800.diff,
> AVRO-1443.20140202-182611-0800.svndiff, AVRO-1443.20140204-124549-0800.diff
>
>
> Ideally, wherever a generic record builder is expected, one should be able to
> supply a builder for a specific record.
> That could happen by making SpecificRecordBuilderBase (and
> SpecificErrorBuilderBase?) a subclass of GenericRecordBuilder.
> Since SpecificRecordBase implements GenericRecord, it should be possible with
> minimal effort.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
