[ 
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948407#comment-13948407
 ] 

Doug Cutting commented on AVRO-1402:
------------------------------------

Tom, this is looking good.  A few issues:
 - Changing the CustomEncoding API makes this incompatible.  Also, reflect is 
perhaps not the appropriate package for this.  So, even though the API is 
almost identical to CustomEncoding, it might be preferable to add a new one, 
like RecordMapping.
 - It won't work to put these in unions without somehow modifying 
GenericData#getSchemaName.  We should probably extend isRecord() to call some 
isRecordMapped(Object) predicate.
 - Do we need a "CustomEncoding" schema attribute?  We need an 
isRecordMapped(Schema) predicate, but we might just key off of 
Schema#getFullName().  In the specification we can add a list of records that 
implementations might specially handle, like org.apache.avro.Decimal.  Adding 
an attribute seems redundant.

> Support for DECIMAL primitive type
> ----------------------------------
>
>                 Key: AVRO-1402
>                 URL: https://issues.apache.org/jira/browse/AVRO-1402
>             Project: Avro
>          Issue Type: New Feature
>    Affects Versions: 1.7.5
>            Reporter: Mariano Dominguez
>            Priority: Minor
>              Labels: Hive
>         Attachments: AVRO-1402.patch, AVRO-1402.patch
>
>
> Currently, Avro does not seem to support a DECIMAL type or equivalent.
> http://avro.apache.org/docs/1.7.5/spec.html#schema_primitive
> Adding DECIMAL support would be particularly interesting when converting 
> types from Avro to Hive, since DECIMAL is already a supported data type in 
> Hive (0.11.0).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to