[
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069485#comment-14069485
]
Sachin Goyal commented on AVRO-680:
-----------------------------------
Thanks [~cutting].
I have confirmed that the changes are in sync with the original patch.
\\
The change in ReflectDatumWriter.java
{code}
else if (datum instanceof Map
&& ReflectData.isMapWithNonStringKeysSchema(schema))
datum = ((Map)datum).entrySet();
{code}
corresponds to the following code in ReflectData.java
{code}
} else if (key != String.class) { // non-String map
Schema nsMapSchema =
createNonStringMapSchema (params[0], params[1], names);
nsMapSchema.addProp(CLASS_PROP, raw.getName());
return nsMapSchema;
}
{code}
So ReflectData proactively converts the schema for non-string map-keys.
And that's why, when the same-type of object is seen in ReflectDataWriter.java,
the only thing it expects is an array of key-value records which we give by
calling
{code}
((Map)datum).entrySet()
{code}
\\
\\
Could you please share the diff/patch command you used to generate this patch
file?
This will help me in generating patches in the future.
\\
Also, thanks for 80-column change.
I wonder why the maven check-style did not catch it?
> Allow for non-string keys
> -------------------------
>
> Key: AVRO-680
> URL: https://issues.apache.org/jira/browse/AVRO-680
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.7.6, 1.7.7
> Reporter: Jeremy Hanna
> Attachments: AVRO-680.patch, non_string_map_keys.zip,
> non_string_map_keys2.zip, non_string_map_keys3.zip
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible
> solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an
> > alternative to a 'map' that will allow me to store an association of bytes
> > keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field. So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible? E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug
--
This message was sent by Atlassian JIRA
(v6.2#6252)
