[
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339158#comment-14339158
]
Ryan Blue commented on AVRO-680:
--------------------------------
[~sachingoyal], thanks for the update! I found a couple more things that I
missed last time (this is why I like pull requests better) so there are a few
things to fix on the PR.
Then there are a couple other items:
1. Are you sure we can't get the type of a map at the top level? It seems like
we should be able to based on the same inspection that you use in
{{isNonStringMap(Object)}}.
2. Empty maps are assumed to be String maps; should this be an option?
I'd still prefer not to use the fingerprint, but other than risking collision
on record names, I can't think of a much better solution. I don't think this is
a blocker.
> Allow for non-string keys
> -------------------------
>
> Key: AVRO-680
> URL: https://issues.apache.org/jira/browse/AVRO-680
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.7.6, 1.7.7
> Reporter: Jeremy Hanna
> Attachments: AVRO-680.patch, AVRO-680.patch, AVRO-680.patch,
> PERF_8000_cycles.zip, isMap_Call_Hierarchy.png, non_string_map_keys.zip,
> non_string_map_keys2.zip, non_string_map_keys3.zip,
> non_string_map_keys4.patch, non_string_map_keys5.patch,
> non_string_map_keys6.patch, non_string_map_keys7.patch,
> non_string_map_perf.txt, non_string_map_perf2.txt, original_perf.txt
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible
> solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an
> > alternative to a 'map' that will allow me to store an association of bytes
> > keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field. So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible? E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
