[ 
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115861#comment-14115861
 ] 

Doug Cutting commented on AVRO-680:
-----------------------------------

The bytes/cycle do not indicate performance and probably should be removed from 
Perf output.

The timings are what we care about.  These need to be run on a relatively 
unloaded machine, and will still vary from run to run, but are the best we can 
do.  We need to watch for things that are consistently faster or slower.  I 
don't see any strong patterns in the data you posted.  What JVM did you use?  
What OS?

It would be great to have something that took a pair of runs and identified 
those tests that varied by more than a few percent.  Then we could re-run just 
those to check whether it was spurious.  We also might try increasing CYCLES to 
see if that decreases the inter-run variations.

> Allow for non-string keys
> -------------------------
>
>                 Key: AVRO-680
>                 URL: https://issues.apache.org/jira/browse/AVRO-680
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.7.6, 1.7.7
>            Reporter: Jeremy Hanna
>         Attachments: AVRO-680.patch, AVRO-680.patch, 
> isMap_Call_Hierarchy.png, non_string_map_keys.zip, non_string_map_keys2.zip, 
> non_string_map_keys3.zip, non_string_map_keys4.patch, 
> non_string_map_keys5.patch, non_string_map_keys6.patch, 
> non_string_map_keys7.patch, non_string_map_perf.txt, 
> non_string_map_perf2.txt, original_perf.txt
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible 
> solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an 
> > alternative to a 'map' that will allow me to store an association of bytes 
> > keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field.  So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible?  E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to